Fix cozy-ui-plus path and package.json issues#2983
Conversation
An old version of cozy-interapp was hardcoded in cozy-ui-plus making IntentDialogOpener unable to return a result. Let's set it as peerDep as our other internal deps. BREAKING CHANGE: You need cozy-interapp >= 0.17.1
WalkthroughThe cozy-ui-plus package was updated to modify dependencies and reorganize component imports. The 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/cozy-ui-plus/package.json (1)
70-70: Constrain thecozy-interapppeer range to the current minor line.The range
>=0.17.1is too broad for a0.xpackage. In pre-1.0 semver, even minor bumps (e.g.,0.18.0) can introduce breaking changes. Use^0.17.1(expands to>=0.17.1 <0.18.0) or an explicit upper bound>=0.17.1 <0.18.0to avoid accidental breaking upgrades.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cozy-ui-plus/package.json` at line 70, The peer dependency range for "cozy-interapp" is too permissive (">=0.17.1"); update the version range in package.json to constrain to the current minor line for the 0.x series—replace ">=0.17.1" with either "^0.17.1" or the explicit upper bound ">=0.17.1 <0.18.0" to prevent accidental incompatible upgrades.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/cozy-ui-plus/package.json`:
- Line 70: The peer dependency range for "cozy-interapp" is too permissive
(">=0.17.1"); update the version range in package.json to constrain to the
current minor line for the 0.x series—replace ">=0.17.1" with either "^0.17.1"
or the explicit upper bound ">=0.17.1 <0.18.0" to prevent accidental
incompatible upgrades.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ef08b089-1d71-4922-b52a-a0290ff13cb7
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
packages/cozy-ui-plus/package.jsonpackages/cozy-ui-plus/src/FilePicker/FilePickerBody.jsxpackages/cozy-ui-plus/src/FilePicker/index.jsx
Summary by CodeRabbit